On Thu 20 Jul 2006 at 08:27AM, James Carlson wrote:
> Dan Price writes:
> >         http://cr.grommit.com/~dp/webrev.1/
> 
> Interesting ...
> 
> Two suggestions (besides the ones others have mentioned):
> 
>   - Not wild about frames, but on the frames diff, it'd be nice to
>     place the delta comments outside of the scrolling area.  That
>     probably shouldn't scroll away.  (Or at least shouldn't scroll
>     with the code.)

My concern was that if the list of deltas is long, it could really limit
the space.  I suspect that no one really uses the frames anyway,
so I didn't want to spend too much time on it.

>   - It'd be nice to be able to generate webrevs that can be placed on
>     grommit.  I always have to hack away at the generated html to fix
>     references to CRs and ARC materials, and it'd be nice if I could
>     just tell webrev "make one for the world."

Yes, I'm considering adding something like 'webrev -O' meaning "open"--
but if others have a better suggestion for toggling this behavior, or
how it should be implemented, please let me know.

        -dp

-- 
Daniel Price - Solaris Kernel Engineering - [EMAIL PROTECTED] - blogs.sun.com/dp
_______________________________________________
tools-discuss mailing list
[email protected]

Reply via email to