Roland Mainz wrote:
Hi!
----
I just found
http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=6510773
("webrev could be portable") which tries to get "webrev" working with
"pdksh". AFAIK this this bug qualifies for a "WONTFIX" because "pdksh"
is obsolete. It implements only a subset of ksh88 and is AFAIK no longer
maintained (last update was around 1999) and IMHO investing time to get
"webrev" working with "pdksh" is wasted time (and the patch in the bug
is incomplete anyway as there are much more differnces between "pdksh"
and ksh88, AFAIK it will require to maintain two seperate versions of
"webrev" to get this working properly).
----
Well I'm going to fix it anyway regardless of the difference between ksh
variants the fixes don't appear to require two versions of webrev at all.
I have the fixes from the original submitted included in my version of
webrev that I'm adding Mercurial support to and it works just fine.
Now personally I like the changes this fix proposed because it puts the
code into the style I would have used originally, ie while do < rather
than cat | while do.
Did you actually look at what the fixes are ?
--
Darren J Moffat
_______________________________________________
tools-discuss mailing list
tools-discuss@opensolaris.org
