Darren J Moffat wrote: > Roland Mainz wrote: > > I just found > > http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=6510773 > > ("webrev could be portable") which tries to get "webrev" working with > > "pdksh". AFAIK this this bug qualifies for a "WONTFIX" because "pdksh" > > is obsolete. It implements only a subset of ksh88 and is AFAIK no longer > > maintained (last update was around 1999) and IMHO investing time to get > > "webrev" working with "pdksh" is wasted time (and the patch in the bug > > is incomplete anyway as there are much more differnces between "pdksh" > > and ksh88, AFAIK it will require to maintain two seperate versions of > > "webrev" to get this working properly). > > Well I'm going to fix it anyway regardless of the difference between ksh > variants the fixes don't appear to require two versions of webrev at all.
No, but if you want to maintain compatibilty to pdksh then we either cannot use any newer POSIX or ksh93 constructs (like associative arrays) in that code or we have to maintain to seperate sources - one for pdksh (or port it to plain bourne shell and disallow any usage of newer shell constructs to make sure the script becomes a real pain) and one for POSIX/ksh93 shells. > I have the fixes from the original submitted included in my version of > webrev that I'm adding Mercurial support to and it works just fine. > > Now personally I like the changes this fix proposed because it puts the > code into the style I would have used originally, ie while do < rather > than cat | while do. > > Did you actually look at what the fixes are ? Yes, but my comment was of a more generic nature. And at some point I am wondering more and more why I am doing all the work with ksh93 on Solaris when some of the more interesting (potential) consumers are kept at a strict "pdksh-compatibilty" level. Or short: It's frustrating. ---- Bye, Roland -- __ . . __ (o.\ \/ /.o) [EMAIL PROTECTED] \__\/\/__/ MPEG specialist, C&&JAVA&&Sun&&Unix programmer /O /==\ O\ TEL +49 641 7950090 (;O/ \/ \O;) _______________________________________________ tools-discuss mailing list tools-discuss@opensolaris.org
