"James C. McPherson" wrote: > as I mentioned to Rainer eariler this evening, I've been working > on changes for the following CRs: > > 6414832 SUNWonbld gk account should be removed > 6536468 date in Nevada motd should be changed > 6855668 webrev mangles dates in non-Romanised locales > 6866716 estimation of max-jobs for /.make.machines is incorrect > 6589104 make POUND_SIGN less of a drag > 6750554 build rule for mcs gives shell+date a real workout > > I'd like to get review comments from the community within the > next 2 days (by 8pm Australia/Queensland time on Thursday 24th), > so that I've got a chance of making the current build. > > The webrev is available at > > http://cr.opensolaris.org/~jmcp/6414832/webrev
Quick 5min race through http://cr.opensolaris.org/~jmcp/6414832/webrev/rfes.patch ... 1. Please fix the following warnings (for both ksh88 and ksh93 scripts ; shcomp only warns about POSIX shell issues and does not enforce anything beyond that): $ shcomp -n gen_make.machines.sh /dev/null gen_make.machines.sh: warning: line 35: `...` obsolete, use $(...) gen_make.machines.sh: warning: line 38: `...` obsolete, use $(...) gen_make.machines.sh: warning: line 39: `...` obsolete, use $(...) gen_make.machines.sh: warning: line 40: `...` obsolete, use $(...) gen_make.machines.sh: warning: line 42: `...` obsolete, use $(...) gen_make.machines.sh: warning: line 50: `...` obsolete, use $(...) gen_make.machines.sh: warning: line 50: `...` obsolete, use $(...) gen_make.machines.sh: warning: line 51: `...` obsolete, use $(...) gen_make.machines.sh: warning: line 51: `...` obsolete, use $(...) > --- /dev/null Tue Sep 22 06:22:04 2009 > +++ new/usr/src/tools/gk/gen_make.machines.sh Tue Sep 22 06:22:03 2009 > @@ -0,0 +1,53 @@ > +#!/bin/ksh93 Please change this to /usr/bin/ksh93 > +if [ -n "$EXISTING" ]; then > + $ECHO "Your existing \$HOME/.make.machines has a concurrency \c" > + $ECHO "setting of $EXISTING for host $THISHOST" > + $ECHO "If you wish to change the setting then this script suggests \c" > + $ECHO "setting concurrency to $max" Please do not use "echo", either use "print" or "printf" instead (see http://opensolaris.org/os/project/shell/shellstyle/#avoid_echo). In this case "printf" may be better since you use arguments. > +else > + $ECHO "`$UNAME -n` max=$max" >> $HOME/.make.machines; Please use $( ... ) or ${ ... ; } command substitutions and _not_ `...` > + $ECHO "dmake concurrency for host `$UNAME -n` set to $max."; Please do not use "echo", either use "print" or "printf" instead (see http://opensolaris.org/os/project/shell/shellstyle/#avoid_echo) > --- old/usr/src/tools/scripts/bldenv.sh Tue Sep 22 06:22:05 2009 > +++ new/usr/src/tools/scripts/bldenv.sh Tue Sep 22 06:22:04 2009 > @@ -278,6 +278,13 @@ > esac > done > > +RELEASE_DATE=$(LANG=C date +"%B %Y") > +BUILD_DATE=$(LANG=C date +%F) Please use LC_ALL to override the date format (since LANG may always be overriden with LC_* or LC_ALL). ---- Bye, Roland -- __ . . __ (o.\ \/ /.o) roland.ma...@nrubsig.org \__\/\/__/ MPEG specialist, C&&JAVA&&Sun&&Unix programmer /O /==\ O\ TEL +49 641 3992797 (;O/ \/ \O;) _______________________________________________ tools-discuss mailing list tools-discuss@opensolaris.org
