Danek Duvall wrote:
James C. McPherson wrote:
http://cr.opensolaris.org/~jmcp/6414832/webrev
Is the new way of computing POUND_SIGN in Makefile.master on top of setting
POUND_SIGN in nightly and bldenv just belt and suspenders? Shouldn't the
first do the trick? (Cute trick, BTW.)
gen_make.machines.sh:
- line 30: I'd just set PATH=/usr/bin:/usr/sbin and not bother with
setting variables for all the commands, especially since you're not
allowing folks to override them from the outside.
- line 39: Since you're in ksh93, you can skip running expr and use the
more readable math expression:
max=$(((cpus + 1) * 2))
- line 40: might
kstat -p ::cpu_info0:clock_MHz | awk '{print $1}'
be more appropriate?
Actually, I think that this line (40) can just be deleted.
"speed" does not appear to be used by the script, at all.
Darren
_______________________________________________
tools-discuss mailing list
tools-discuss@opensolaris.org
