On Tue, Sep 22, 2009 at 08:54:18AM -0700, Danek Duvall wrote:
> James C. McPherson wrote:
> 
> > http://cr.opensolaris.org/~jmcp/6414832/webrev

> gen_make.machines.sh:

>   - line 40: might
> 
>         kstat -p ::cpu_info0:clock_MHz | awk '{print $1}'
> 
>     be more appropriate?

Line 40 sets the variable 'speed' which then isn't referenced anywhere.
Previously, SUNWonbld/postinstall did the following:

-       speed=`$PSRINFO -v | head -3 | $AWK '/MHz/ { print $6 }'`;
-       if [ $speed -gt "500" ]; then
-               max=`expr $max '*' 2`;
-       fi

Was a similar check for $speed (perhaps using a different MHz value) left
out intentionally here?  Or should line 40 just be removed?


> Danek

-Brent
_______________________________________________
tools-discuss mailing list
tools-discuss@opensolaris.org

Reply via email to