Thanks for the comments!
>>>>> John Beck writes:
JBeck> * Install.sh
JBeck> Does $VERBOSE need to be quoted (existing issue, but still)?
Yes, that looks like a good thing to do. Will fix.
JBeck> * cryptodrop.sh
JBeck> Error message nit: "could not" should be used for situations
JBeck> where a failure may have been temporary (e.g., ENOMEM) whereas
JBeck> "cannot" should be used where a failure is likely to happen
JBeck> repeatedly (e.g., EPERM). Since you don't seem to check for
JBeck> "was this transient?", "could not" would probably be better.
Will fix.
JBeck> * nightly.sh
JBeck> * 1760-1 nit: you have already made sure the $1 is non-null, so
JBeck> you don't need to quote it any more.
Well, quotes also protect against paths that have a blank in them.
Not that I expect people to use such paths, but I'd rather be safe.
JBeck> * 2798: brackets?
As we discussed off-list, brackets aren't needed, but I'll restructure
the code slightly to be clearer.
crypto_is_present >> "$LOGFILE"
if (( $? != 0 )); then
...
cheers,
mike
_______________________________________________
tools-discuss mailing list
tools-discuss@opensolaris.org
