On Thu, 14 Jan 2010, Mike Kupfer wrote:
Mike Kupfer writes:
Valerie Bubb Fenwick writes:
VF> I'm sorry I haven't reviewed yet, do you have an updated webrev that
VF> incorporates the comments so far? thanks!
Mike> Not yet. Probably later tonight or tomorrow.
New webrevs are available.
Full: http://cr.opensolaris.org/~kupfer/6855998.100114/
Incremental: http://cr.opensolaris.org/~kupfer/6855998.100105-100114/
(The old one is now available at
http://cr.opensolaris.org/~kupfer/6855998.100105/.)
Hi gang -
I had a few nits on comments in the files, which Mike fixed,
and everything else looks good to me. While I was never thrilled
with where the crypto tar ball ends up (after being built), I understand
that Mike chose the location based on GK request, and as nobody
else had issues with it, I'm fine with it as is.
I am no expert on Install, but did thoroughly review the Makefile
changes and the changes to signproto.sh and the new findcrypto.sh.
Thanks, Mike!
Valerie
--
Valerie Fenwick, http://blogs.sun.com/bubbva/ @bubbva
Solaris Security Technologies, Developer, Sun Microsystems, Inc.
17 Network Circle, Menlo Park, CA, 94025.
_______________________________________________
tools-discuss mailing list
tools-discuss@opensolaris.org
