On Tue, Jan 05, 2010 at 11:21:24AM -0800, Mike Kupfer wrote:
> I'm looking for code review feedback for the following wad:
>
> 6855998 put signed crypto in its own tarball, not with the closed bins
> 6590779 bindrop cleanup: remove grfans, i2c_svc
> 6590785 bindrop: grppm is okay
> 6597124 bindrop: dis is now open
> 6702310 bindrop should not blacklist pcn(7D)
> 6881398 bindrop no longer needs to filter out audioens
> 6889306 pcitool should not be dropped by bindrop
> 6891710 bindrop: phx is gone
> 6897972 README.opensolaris has out of date compiler info
>
> It's fairly large, so I recommend starting with either the
> bugs.opensolaris.org (Bugster) entry for 6855998 or the draft flag-day
> email[1] to get oriented.
>
> The webrev is at http://cr.opensolaris.org/~kupfer/6855998/.
usr/src/tools/scripts/cryptodrop.sh:
107 Should mktemp get a six-digit template?
122 This relies on findcrypto emitting relative paths? (Ie no test
for "/" needed?)
131 If we care overly much about performance here, we could prune the
list via dirname/sort -u before we pass the elements to alldirs.
But this is relatively short, as lists go, right?
usr/src/tools/scripts/mktpl.pl
- I'm not really a big Perl guy. Seems like the maketpl calls on
151-153 could be guarded by !opt_c, but instead rely on the lists in
question being empty?
usr/src/tools/scripts/nightly.1
571-575 Does this imply a need to update default gatekeeper and
developer env files, as well as open?
usr/src/tools/scripts/nightly.sh
81 Should this use $BUILD_DATE?
--Mark
> I've also posted draft changes to the DevRef and the ON Known Issues
> page at http://hub.opensolaris.org/bin/view/Project+onnv/6855998.
> I'll be posting a draft for the ON QuickStart page later today. (To
> view diffs, view the page that you want to review, hover the mouse
> over Show, then click on History.)
>
> thanks,
> mike
>
> Footnotes:
> [1] http://cr.opensolaris.org/~kupfer/6855998-flag-day.txt
>
> _______________________________________________
> tools-discuss mailing list
> tools-discuss@opensolaris.org
_______________________________________________
tools-discuss mailing list
tools-discuss@opensolaris.org
