#23846: Use libtool for building shared library -------------------------------------------------+------------------------- Reporter: hellais | Owner: sbs Type: enhancement | Status: | needs_review Priority: Medium | Milestone: Tor: | 0.3.4.x-final Component: Core Tor/Tor | Version: Severity: Normal | Resolution: Keywords: tor-mobile, s8-api, | Actual Points: 034-triage-20180328 034-included-20180402 | Parent ID: #23684 | Points: Reviewer: ahf | Sponsor: | Sponsor8 -------------------------------------------------+-------------------------
Comment (by catalyst): Thanks for the pull request! It's good to see Travis passing. I'm not very familiar with libtool, so sorry if I miss anything obvious. This seems to switch from building static libraries to building shared libraries, if I'm reading the rust warning correctly. Is this something we want? It could make the build more fragile in some ways. Do we know how this will affect Windows builds? The `.$(OBJEXT)` vs `.lo` change makes me nervous. I also made a minor comment on the pull request about verbosity. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23846#comment:14> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs