#23846: Use libtool for building shared library
 Reporter:  hellais                              |          Owner:  sbs
     Type:  enhancement                          |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-mobile, s8-api,                  |  Actual Points:
  034-triage-20180328 034-included-20180402 034  |
  -roadmap-subtask                               |
Parent ID:  #25510                               |         Points:
 Reviewer:  ahf                                  |        Sponsor:
                                                 |  Sponsor8

Comment (by Hello71):

 Replying to [comment:21 nickm]:
 > So, I've looked over the codebase and made a couple of changes in a
 branch called "libtool_hack", including a workaround for the Rust warning
 issue.  (It's only a plausible legitimate workaround if Rust builds with
 -fPIC though -- does it?)

 yes. it is highly unlikely that they will stop, due to the numerous
 benefits of PIC and negligible costs, but if so, there will be loud build
 time errors and we can figure it out then. we can safely assume that there
 will always be a way to turn PIC on, since otherwise it would be
 impossible to make even pure-Rust shared libraries.

 >   * How horrible is the above Rust hack?

 personally I think we should just ignore it. this hack will probably cause
 more problems than it solves. I believe the warning only applies to
 obsolete Unix systems that Rust does not and will never support anyways.
 as I said above, if there is any breakage it will be loud and at build
 time anyways.

Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23846#comment:24>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
tor-bugs mailing list

Reply via email to