On Sat, Jan 10, 2009 at 9:42 PM, TK Soh <[email protected]> wrote:
> On Sun, Jan 11, 2009 at 3:19 AM, Steve Borho <[email protected]> wrote:
> > On Sat, Jan 10, 2009 at 9:03 PM, TK Soh <[email protected]> wrote:
> >>
> >> >> What do you mean by hard-code?
> >> >
> >> > The installer patch queue has always patched version.py file so 'hg
> >> > version'
> >> > returns $qbase+tortoisehg.
> >>
> >> I've been wondering if we really should add "+tortoisehg" to hg
> >> version. While it help points to the hg.exe in tortoisehg, it may give
> >> a wrong impression to some people that we have patched mercurial core,
> >> which we don't.
> >
> > Not anymore, we don't. My earlier installers did, but all of those
> changes
> > were eventually merged into Mercurial. The only reason to leave it in
> there
> > is to differentiate THG usage in bug reports (tracebacks).
>
> I'd like view the hg.exe in TortoiseHg as just-another binary version,
> additive-free, of hg. We should take it out, especially since we don't
> patch mercurial core any more (the policy is to link against the
> released versions of Hg only).
>
> This way when issues are posted to the Mercurial list by user using
> TortoiseHg's hg.exe, no one will be distracted by the presumption that
> the problems might be caused by TortoiseHg.
>
Most of the bug reports with Mercurial on Windows (at least lately) deal
with missing modules and other details that are install/build specific. So
"branding" here isn't just for the Mercurial core.
>
> >>
> >> > The build batch file should probably run 'hg id -qr HG > HG-VERSION'
> >> > and then version.py should read that file.
> >>
> >> Do you mean tortoise/version.py? But that will have no effect on 'hg
> >> version'.
> >
> > mercurial/version.py
>
> This will invalidate our claim of not patching mercurial core.
>
It will be a lot more difficult to do this without patching version.py, but
perhaps we can force Mercurial to record it's version before we do the
merges, and then "break" setup.py to prevent the revision ID from being
updated. It would be quite a hack.
--
Steve
------------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It is the best place to buy or sell services for
just about anything Open Source.
http://p.sf.net/sfu/Xq1LFB
_______________________________________________
Tortoisehg-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop
