On Sat, Jan 10, 2009 at 9:03 PM, TK Soh <[email protected]> wrote:
> >> What do you mean by hard-code?
> >
> > The installer patch queue has always patched version.py file so 'hg
> version'
> > returns $qbase+tortoisehg.
>
> I've been wondering if we really should add "+tortoisehg" to hg
> version. While it help points to the hg.exe in tortoisehg, it may give
> a wrong impression to some people that we have patched mercurial core,
> which we don't.
>
Not anymore, we don't. My earlier installers did, but all of those changes
were eventually merged into Mercurial. The only reason to leave it in there
is to differentiate THG usage in bug reports (tracebacks).
>
> > The build batch file should probably run 'hg id -qr HG > HG-VERSION'
> > and then version.py should read that file.
>
> Do you mean tortoise/version.py? But that will have no effect on 'hg
> version'.
>
mercurial/version.py
> >>
> >> I am wondering if we should do this re-org after 0.6. We still target
> >> to release 0.6 in another week.
> >
> > It's up to you how you build 0.6. I'm just trying to lower the barrier
> to
> > entry for contributors.
> > This shouldn't hold up the release.
> >
> >> We also need to copy the qct.py extension from plugins/ to hgext/
> >
> >> Which can be done by the patch queue?
> >
> > Probably better to be done by the batch file, just after qct is merged we
> > can hg cp that file into place. That way the patch queue doesn't need to
> be
> > updated if that file changes.
>
> Good use of mq ;-)
>
If MQ could store that the file moved without having to record the entire
file contents, I would agree. But I don't think that even git diffs do that
correctly.
--
Steve
------------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It is the best place to buy or sell services for
just about anything Open Source.
http://p.sf.net/sfu/Xq1LFB
_______________________________________________
Tortoisehg-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop
