On Thu, Jan 15, 2009 at 3:03 AM, Steve Borho <[email protected]> wrote: > On Sat, Jan 10, 2009 at 9:42 PM, TK Soh <[email protected]> wrote: >> >> On Sun, Jan 11, 2009 at 3:19 AM, Steve Borho <[email protected]> wrote: >> > On Sat, Jan 10, 2009 at 9:03 PM, TK Soh <[email protected]> wrote: >> >> >> >> >> What do you mean by hard-code? >> >> > >> >> > The installer patch queue has always patched version.py file so 'hg >> >> > version' >> >> > returns $qbase+tortoisehg. >> >> >> >> I've been wondering if we really should add "+tortoisehg" to hg >> >> version. While it help points to the hg.exe in tortoisehg, it may give >> >> a wrong impression to some people that we have patched mercurial core, >> >> which we don't. >> > >> > Not anymore, we don't. My earlier installers did, but all of those >> > changes >> > were eventually merged into Mercurial. The only reason to leave it in >> > there >> > is to differentiate THG usage in bug reports (tracebacks). >> >> I'd like view the hg.exe in TortoiseHg as just-another binary version, >> additive-free, of hg. We should take it out, especially since we don't >> patch mercurial core any more (the policy is to link against the >> released versions of Hg only). >> >> This way when issues are posted to the Mercurial list by user using >> TortoiseHg's hg.exe, no one will be distracted by the presumption that >> the problems might be caused by TortoiseHg. >> >> >> >> >> > The build batch file should probably run 'hg id -qr HG > HG-VERSION' >> >> > and then version.py should read that file. >> >> >> >> Do you mean tortoise/version.py? But that will have no effect on 'hg >> >> version'. >> > >> > mercurial/version.py >> >> This will invalidate our claim of not patching mercurial core. > > Hah. I don't know if Matt reads this list or not, but he just re-factored > the way Mercurial versions itself, completely removing version.py. > > http://www.selenic.com/hg/rev/9626819b2e3d
Hmm... maybe he does ;-) ------------------------------------------------------------------------------ This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword _______________________________________________ Tortoisehg-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop
