On Thu, May 21, 2009 at 12:00 AM, Steve Borho <[email protected]> wrote:
> On Wed, May 20, 2009 at 3:11 AM, Yuki KODAMA <[email protected]> wrote:
>> Hi,
>>
>> I just figured out the patch posted by me causes other problem related
>> translation. It fixes the label of file filter checkbox in commit dialog.
>> http://bitbucket.org/tortoisehg/crew/changeset/d6f1b029244f/
>>
>> By this patch, there is no msgid for these labels in the code, because label
>> strings (msgid) are generated by Python code. No "_" (gettext) function
>> in that patch.
>
> Should I backout that patch? If the problem is the string
> concatenation of '_' to the translated text, I think we can simply
> remove the '_'. Not sure anyone would miss those keyboard
> accelerators. I was quite surprised when I activated one on accident.
>
> --
> Steve Borho
>
I just wrote new patch, but you already backouted and removed leading
underbar... ;)
However, it still has problem since the value in 'checks' variable has
translated.
checks = (_('modified'), _('added'), _('removed'))
It will make effect following code. So I write new patch and post it right now.
I also though keyboard accelerators of checkbox often suprise me.
I'll keep your change (removed leading underbar) in new patch.
Thanks.
Yuki
------------------------------------------------------------------------------
Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT
is a gathering of tech-side developers & brand creativity professionals. Meet
the minds behind Google Creative Lab, Visual Complexity, Processing, &
iPhoneDevCamp asthey present alongside digital heavyweights like Barbarian
Group, R/GA, & Big Spaceship. http://www.creativitycat.com
_______________________________________________
Tortoisehg-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop
