Thanks Jarkko for the review. I will address all your comments in my next version of patches.
Thanks & Regards, - Nayna On 08/30/2016 12:40 PM, Jarkko Sakkinen wrote: > On Tue, Aug 30, 2016 at 12:50:12AM -0400, Nayna Jain wrote: >> Existing TPM2.0 support lacks the support for eventlog securityfs file. >> This patch adds the binary_bios_measurements to TPM2.0 eventlog >> securityfs file. >> >> Additionally, it also includes the review feedbacks as suggested by >> Jason. >> >> Further, commit msg subject line is prefixed with tpm as was suggested >> by Jarkko. > > Please start using get_maintainers.pl... > >> Changelog v3: >> >> * Includes the review feedbacks as suggested by Jason >> * Split of patches into one patch per idea >> * Generic open() method for ascii/bios measurements >> * Replacement of of **bios_dir with *bios_dir[3] >> * Verifying readlog() is successful before creating >> securityfs entries >> * Generic readlog() to check for ACPI/OF in sequence >> * read_log_of() method now uses of_node propertry rather than >> calling find_device_by_name >> * read_log differentiates vtpm/tpm using its compatible property >> * Cleans pr_err with dev_dbg >> * Commit msgs subject line prefixed with tpm > > Where is the changlog for v2? > > /Jarkko > >> >> Nayna Jain (7): >> tpm: Define a generic open() method for ascii & bios measurements. >> tpm: Replace the dynamically allocated bios_dir as struct dentry >> array. >> tpm: Validate the eventlog access before tpm_bios_log_setup >> tpm: Redefine the read_log method to check for ACPI/OF properties >> sequentially >> tpm: Replace the of_find_node_by_name() with dev of_node property >> tpm: Moves the eventlog init functions to tpm_eventlog_init.c >> tpm: Adds securityfs support for TPM2.0 eventlog >> >> drivers/char/tpm/Makefile | 13 +- >> drivers/char/tpm/tpm-chip.c | 21 +--- >> drivers/char/tpm/tpm.h | 7 +- >> drivers/char/tpm/tpm2.h | 85 +++++++++++++ >> drivers/char/tpm/tpm2_eventlog.c | 224 >> +++++++++++++++++++++++++++++++++++ >> drivers/char/tpm/tpm_acpi.c | 19 +-- >> drivers/char/tpm/tpm_eventlog.c | 154 +----------------------- >> drivers/char/tpm/tpm_eventlog.h | 26 ++-- >> drivers/char/tpm/tpm_eventlog_init.c | 153 ++++++++++++++++++++++++ >> drivers/char/tpm/tpm_of.c | 65 ++++++---- >> 10 files changed, 543 insertions(+), 224 deletions(-) >> create mode 100644 drivers/char/tpm/tpm2.h >> create mode 100644 drivers/char/tpm/tpm2_eventlog.c >> create mode 100644 drivers/char/tpm/tpm_eventlog_init.c >> >> -- >> 2.5.0 >> >> >> ------------------------------------------------------------------------------ >> _______________________________________________ >> tpmdd-devel mailing list >> tpmdd-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/tpmdd-devel > ------------------------------------------------------------------------------ _______________________________________________ tpmdd-devel mailing list tpmdd-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
