While working on i18n branch, I get some undesirable representaions in
table header string. Because there's no semantics of word-boundary in
Japanese text, browser may break between each characters inside of
narrow column. For example in admin/ticket/priorities panel, you can
see the table header like:
+-----+-------+---------+-------+
| | Name | Default | Order |
+-----+-------+---------+-------+
| [x] | xxxxx | o | ----- |
But it may shown like this in Japanese:
+-----+-------+----+-------+
| | | 規 | |
| | | 定 | |
| | 名称 | 値 | 順序 |
+-----+-------+----+-------+
| [x] | xxxxx | o | ----- |
(Note: Japanese "規定値" is equal to English "default")
This is because column width is specified by style and width of
"規定値" is larger than it. It may be same in Chinese and Korean.
I feel this is ugry to see. So I'd prefer to set 'nowrap' style in
these table header. Here is a patch.
{{{
#!patch
diff -r cf324daebaf5 trac/htdocs/css/trac.css
--- a/trac/htdocs/css/trac.css Tue Sep 04 16:36:17 2007 +0900
+++ b/trac/htdocs/css/trac.css Thu Sep 06 03:03:34 2007 +0900
@@ -406,6 +406,7 @@ table.listing thead th {
font-weight: bold;
padding: 2px .5em;
vertical-align: bottom;
+ white-space: nowrap;
}
table.listing thead th :link:hover, table.listing thead th :visited:hover {
background-color: transparent;
}}}
With this patch, previous example will be shown like:
+-----+-------+--------+-------+
| | 名称 | 規定値 | 順序 |
+-----+-------+--------+-------+
| [x] | xxxxx | o | ----- |
P.S.
I've tried to make a ticket on t.e.o. for this issue,
but I got following exception. So I posted it to ML.
Traceback (most recent call last):
File "/usr/lib/python2.4/site-packages/trac/web/main.py", line 406,
in dispatch_request
dispatcher.dispatch(req)
File "/usr/lib/python2.4/site-packages/trac/web/main.py", line 237,
in dispatch
resp = chosen_handler.process_request(req)
File "/usr/lib/python2.4/site-packages/trac/ticket/web_ui.py", line
138, in process_request
self._do_create(req, db)
File "/usr/lib/python2.4/site-packages/trac/ticket/web_ui.py", line
199, in _do_create
self._validate_ticket(req, ticket)
File "/usr/lib/python2.4/site-packages/trac/ticket/web_ui.py", line
77, in _validate_ticket
for field, message in manipulator.validate_ticket(req, ticket):
File "build/bdist.linux-x86_64/egg/tracspamfilter/adapters.py", line
67, in validate_ticket
File "build/bdist.linux-x86_64/egg/tracspamfilter/api.py", line 133, in test
File "build/bdist.linux-x86_64/egg/tracspamfilter/model.py", line
135, in insert
File "/usr/lib/python2.4/site-packages/trac/db/util.py", line 50, in execute
return self.cursor.execute(sql_escape_percent(sql), args)
File "/usr/lib/python2.4/site-packages/trac/db/util.py", line 50, in execute
return self.cursor.execute(sql_escape_percent(sql), args)
ProgrammingError: current transaction is aborted, commands ignored
until end of transaction block
--
Shun-ichi GOTO
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Trac
Development" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/trac-dev?hl=en
-~----------~----~----~----~------~----~------~--~---
