Sorry for my late reply.
On 29.09.2013 17:09, Steffen Hoffmann wrote:
> Right. From my point of view we need to build a slim TracNotification
> API compatibility layer, of course using AnnouncerPlugin native code as
> much as possible. But then we might replace to code in a copy-n-paste
> fashion, in the corresponding announcer sandbox branch.
"API compatibility layer": I assume the main goal is existing plugins
that use the old API remain working.
However supporting new features with the old API is not a goal. So I
think we can achieve all that's needed by leaving the existing code
"untouched" (or only refactoring it where code can be shared without
affecting the old API.)
My first batch of proposed code changes [1] already covers most of that
I think.
"using AnnouncerPlugin native code as much as possible": I'm not sure I
understand what you mean here. Using as much AnnouncerPlugin code is not
a goal in itself for me.
Or do you mean as much code as possible should be in the "native style"
of AnnouncerPlugin, i.e. more component- and extension interface-oriented?
"announcer sandbox branch": Do you mean the old SVN branch on t.e.o.
[2]? I wasn't planning to use a SVN branch, as we have mostly switched
to HG and Git for WIP instead.
> I've been stuck doing an extensive visual and logic re-factoring towards
> a more universal subscription configuration interface for tickets
> (th:#10622 [1]). Maybe this could be made even more general using a
> plugable Interface with other subscription configuration providers?
> While I feel, that I've almost done the thing for tickets, this would
> again be a big challenge, that I'd likely have to postpone. A joint
> effort on the other hand could make it happen.
I sadly haven't followed your latest work on Announcer closely.
universal interface, th:#10622, plugable Interface: That
conditional-subs_preview_v2 looks interesting. Is that just a mockup or
was this implemented and is the code available somewhere?
Required new / changed interfaces would be the most important to discuss
before integration. Improvements to the implementation can easily be
postponed I think.
"extensive visual ... re-factoring": I like the icon buttons, and was
planning to do something similar. In my own experiments [3] I removed
the blue titles and boxes, as they are too different for Trac core UI.
[1]
http://trac.edgewall.org/log/psuter/?rev=9b98c20b0b4414b2387322ac970c53a8e17f621b
[2] http://trac.edgewall.org/wiki/TracDev/Branches/Announcer
[3]
http://trac.edgewall.org/attachment/wiki/TracDev/Proposals/AdvancedNotification/notification-subscription-prefs.png
--
You received this message because you are subscribed to the Google Groups "Trac
Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/trac-users.
For more options, visit https://groups.google.com/groups/opt_out.
