Anish Shah added the comment: > Why do you need to reconstruct the url in this case? Why not just assigning > the one you verified is ok?
I'm reconstructing because URL might contain fragment identifier/query string. What do you think? > Make shorter, 'github_prs' is enough. > 'id', 'no', 'pr_no' one of them will be sufficient, as well. I will change this. But, I will need to change this in all the patches that I have submitted. > Have we discussed the possibility of having the links being crossed when the > PR is merged or at least having a separate column with the state, I think we > did. I have added a 'state' field in issue590 _______________________________________________________ PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za> <http://psf.upfronthosting.co.za/roundup/meta/issue586> _______________________________________________________ _______________________________________________ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
