On Do, 2008-08-21 at 12:45 +0200, Julen wrote:
> F Wolff(e)k dio:
> > On Do, 2008-08-21 at 11:01 +0200, Julen wrote:
> >> On Mon, Aug 18, 2008 at 9:54 AM, Dwayne Bailey
> <[EMAIL PROTECTED]> wrote:
> >>> On Fri, 2008-08-15 at 12:54 +0200, F Wolff wrote:
...
> > The anchors on that page is sorted alphabetically, so we could just
> go
> > to the first one, sorted according to English sorting rules. We just
> > need to pass that information to the template to construct the
> correct
> > URL. The only common case where multiple checks are reviewed is part
> of
> > "quick translate" - we could simply not make the link clickable in
> this
> > case. Either of these alternatives is OK for now, I think.
>
> Check this please. If there's more than one check, the anchor links
> to
> the entire document, otherwise to the concrete check. I've also added
> quotes to each check name, as it was marked as TODO.
>
> Julen.
>
I'll put some comments inline - I think there are a few small issues.
>
>
>
>
>
>
> plain text
> document
> attachment
> (hyperlink.patch)
> diff --git a/templates/translatepage.html b/templates/translatepage.html
> index 68acc76..4771d49 100644
> --- a/templates/translatepage.html
> +++ b/templates/translatepage.html
> @@ -283,8 +283,9 @@ from Pootle.templates import pootlepage, navbar
> <input name="action" value="translate"
> title="${assigns.action_title}"/>
> <input name="doassign" type="submit" value="${assigns.submit_text}"/>
> </form>
> - <div class="side" py:if="defined('checking_text')"
> py:content="checking_text">
> - checking has-suggestion, etc
> + <div class="side" py:if="defined('checking_text')">
> + <img src="${baseurl}images/information.png" class="checkinfo" alt="" />
> + <a href="${checking_url}" target="_blank"
> py:content="checking_text">checking has-suggestion, etc</a>
> </div>
> </div>
> <div py:replace="pootlepage.user_links(links, session, uidir, uilanguage,
> baseurl, show_assigns())"/>
Personally I would add the URL here in the template, since that might be
something that a site might want to customise. Of course I'm guessing
here, and I assume there is something to be said for both the code and
the template.
> diff --git a/translatepage.py b/translatepage.py
> index 2661ae1..f081bad 100644
> --- a/translatepage.py
> +++ b/translatepage.py
> @@ -224,10 +224,13 @@ class TranslatePage(pagelayout.PootleNavPage):
> self.templatevars["assigns"] = self.getassignbox()
> if self.pofilename is not None:
> if self.matchnames:
> - checknames = [matchname.replace("check-", "", 1) for matchname in
> self.matchnames]
> - # TODO: put the following parameter in quotes, since it will be
> foreign in all target languages
> + checknames = ["'%s'" % matchname.replace("check-", "", 1) for
> matchname in self.matchnames]
This will add '..' around each name, but this is not the same for all
languages (French uses «...», for example). So we need to edit the
string...
> # l10n: the parameter is the name of one of the quality checks, like
> "fuzzy"
> self.templatevars["checking_text"] = self.localize("checking %s", ",
> ".join(checknames))
... here,
but we can't do that, since I've already frozen the translations for
this release. Let's do it for 1.3 or whatever is next. Perhaps we can
add an l10n comment to encourage translators to quote the check names if
necessary.
I'm playing with the idea of making only the the check name(s)
clickable, I guess we can do all of this.
For now, let's just address these issues now without breaking the string
freeze.
Keep well
Friedel
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Translate-pootle mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/translate-pootle
