On 07/19/12 00:21, Thomas Lübking wrote:
No. 1 should fix paddings (we scan up on reparenting anyway, so there's no need for API changes at all)
Applied, thanks.
No. 2 invokes link handling of the emptyView for the header - i made the slot public but since it's stateless (could be a static if it wasn't a slot) that should not be a problem, yesno?
Applied.
Another option would be to move it up (to a singleton object, so that one can connect(this, SIGNAL(that), Trojita::instance(), SLOT(stuff));
QDesktopServices::openUrl() shall be enough, Trojita is registered as a handler for mailto: (at least for in-app openUrl() calls). I've implemented this now.
The ComposeWidget didn't actually get initialized with correct recipients -- my bad, I've fixed that as well.
(It still doesn't pass along the human-readable recipient name, Redmine #534 [1].)
Note to self: scanning for keywords like "attach" or "patch" and ask whether you forgot to actually do so was one of the greatest things in kmail and will be a must ;-)
Please file a bug [2] so that these ideas don't get lost. Cheers, Jan [1] https://projects.flaska.net/issues/534 [2] https://projects.flaska.net/projects/trojita/issues/new -- Trojita, a fast e-mail client -- http://trojita.flaska.net/
