1) addressbook interface 2) addressbook completion Quick Copy & Paste from my mailer - nearly no time lost ;-)
please notice that the "custom" completer was pretty much a result of the wish to complete comma separated lists
this works, but the parser will likely rank them invalid.I'd still like you to have a short look and if you finally say nay, i'll remove that and send a new patch (currently patches 4 & likey 5 will not apply w/o 1 & 2)
W/o custom completion one could also use a regular QCompleter and reimplement the ::match() function of the model. This rules out remote adressbooks but actually you don't want to (blocking) lookup the network on every keypress either, so one would either require local addressbooks anyway or write an async completion (possible - we update the activities menu async in kwin - as long as you don't have the mouse over a chaning item, everything's just fine ;-)
Last note: if you want to keep the multientry lineedit, it's easy to replace the popup by a combobox droppdown in case you just don't like that
3) for some reason i absolutely don't know the layout was recreated whenever a recipient was removed. Since the layout changed and that wasn't covered in this place, this effectively broke the layout. Unless there's a known good reason and issue for that action, it should just not be there.
4) I changed the behavior of blank recipients being added and removed, see comments in the patch on why
5) replaced the tr("To") -> RecipientKind mapping since it seemed faaar too wonky
Question: should there be a common include for used types (enums, typedefs etc.)?
The current de::e::e::e::p nesting clutters the code quite some. Cheers, Thomas
binUjS9dTyZed.bin
Description: Binary data
0002-utilize-addressbook-interface-in-composer-widget.patch
Description: Binary data
binN1ZkAurhJ9.bin
Description: Binary data
0004-change-dynamic-recp-s-to-timer-on-changes.patch
Description: Binary data
0005-replace-tr-ToCcBcc-with-RecipientKind.patch
Description: Binary data
