Thanks for the patch, I really like it (including the extensive comments
which go along the code) -- good job.
I've added some trivial fixes and it's now available in the
tl-composer-rework branch.
Before I merge it into the master, though, I'd like to decide what to do
with the existing address book implementation contributed by Thomas Gahr
-- the code simply gathered any addresses typed into the input widgets
and stored them into Trojita's QSetings.
Your code obviously provides better functionality; having a full-blown
address book holding structured information is great. On the other hand,
in its present form, it removes the support for this remembering of
entered data.
I'm not sure what'd be the best way to do that. One option might be to
unconditionally add any addresses to the abook file. Is that even
possible? Is that really desirable? What kind of "identifier" (i.e.
QSettings' category name) to use? It might also be perfectly acceptable
to just allow a settings for picking either "trojita-internal storage
only" or "read from abook, no write support".
When we settle on this one, the older code shall be converted to use the
newer API you added.
With kind regards,
Jan
--
Trojita, a fast e-mail client -- http://trojita.flaska.net/
