On Friday, 2013-07-12, Thomas Lübking wrote:

> +++   // TODO QMetaObject::invokeMethod
> +    QTimer::singleShot(0, this, SLOT(doStart()));

Internally this is actually the same thing.

> +protected slots:
> +++   // TODO slots don't have to be virtual
> +    /** @short Reimplement starting job */
> +    virtual void doStart() = 0;

I think you mean that since connect happens at runtime, the name resolution 
would find an equally named slot in a subclass first.

However, this is only true when invoking via Qt meta method call, not when 
called via C++. doStart() being called by invokeMethod/singleshot timer is 
IMHO an implementation detail.

The virtual also makes it very obvious that this is a customization point, the 
pure virtualness even enforces having to think about doing something plugin 
specifiic in there.

Cheers,
Kevin

-- 
Kevin Krammer, KDE developer, xdg-utils developer
KDE user support, developer mentoring

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to