Hi,
--- Eric Dobbs <[EMAIL PROTECTED]> wrote:
> Hi Chris.
>
>
> On Wednesday, April 3, 2002, at 09:36 AM, Chris Kimpton wrote:
>
> > Attached is a revised patch with fixed/new tests to cover the
> > changes. I have also added a test-report task to build-test.xml
> - is
> > this file deprecated and replaced by something in maven?
>
>
> The attached patch, passthru3.diffu, is garbled both in my inbox
> and in
> the archived copy at mail-archive.com. Please resend it.
>
> While you're at it, I noticed a few items in passthru2.diffu that
> were
> not adhering to our coding standards. In particular
>
> } else {
>
> should be
>
> }
> else
> {
>
> same for 'else if' etc.
>
> The one other thing I am unsure about is the change in the
> arguments you
> added to the PropertiesConfiguration constructor. I think it would
>
> probably be better to add a new constructor instead of replacing
> the
> existing one. I don't know what other code might be using the
> existing
> constructor. Otherwise things look good to me.
> Attached is a revised patch file - hopefully this will be readable too. Can someone else take a look at this? Thanks, Chris ===== ------------------------------------------ http://www.soccer2002.org.uk __________________________________________________ Do You Yahoo!? Yahoo! Tax Center - online filing with TurboTax http://taxes.yahoo.com/
passthru4.diffu
Description: passthru4.diffu
-- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
