Hi,
--- Eric Dobbs <[EMAIL PROTECTED]> wrote:
>
>
> The attached patch, passthru3.diffu, is garbled both in my inbox
> and in
> the archived copy at mail-archive.com. Please resend it.
Same here - I will do this tonight when I get to my home machine.
>
> } else {
>
> should be
>
> }
> else
> {
>
> same for 'else if' etc.
I presume it should be
}
else if
{
>
> The one other thing I am unsure about is the change in the
> arguments you
> added to the PropertiesConfiguration constructor. I think it would
> probably be better to add a new constructor instead of replacing
> the
> existing one. I don't know what other code might be using the
> existing
> constructor. Otherwise things look good to me.
I did a new constructor - its the diff that decided to make it look I
amended the old one - I presume you refer to changing this ctor:
- public PropertiesConfiguration(String file, String defaultFile)
+ public PropertiesConfiguration(String file, Configuration
defaultConfig)
but you will see later this line;
+ public PropertiesConfiguration(String file, String defaultFile)
So - that ctor is still there.
Chris
=====
------------------------------------------
http://www.soccer2002.org.uk
__________________________________________________
Do You Yahoo!?
Yahoo! Tax Center - online filing with TurboTax
http://taxes.yahoo.com/
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
