Hi Chris.
On Wednesday, April 3, 2002, at 09:36 AM, Chris Kimpton wrote:
> Attached is a revised patch with fixed/new tests to cover the
> changes. I have also added a test-report task to build-test.xml - is
> this file deprecated and replaced by something in maven?
The attached patch, passthru3.diffu, is garbled both in my inbox and in
the archived copy at mail-archive.com. Please resend it.
While you're at it, I noticed a few items in passthru2.diffu that were
not adhering to our coding standards. In particular
} else {
should be
}
else
{
same for 'else if' etc.
The one other thing I am unsure about is the change in the arguments you
added to the PropertiesConfiguration constructor. I think it would
probably be better to add a new constructor instead of replacing the
existing one. I don't know what other code might be using the existing
constructor. Otherwise things look good to me.
<maven-problems>
I'm copying this email to turbine-maven-dev...
I tried applying the patches in passthru2.diffu but was unable to build
stratum with them. Probably because I have an older installation of
maven on my box here at home. I tried updating my copy of maven from
cvs to remedy that problem, but 'ant -f build-bootstrap.xml boostrap'
failed in two places. The first is apparently because commons logging
is now needed and the second because log4j is not properly configured.
</maven-problems>
Unfortunately, I don't have any more time to work on this tonight and
I'm going to be skiing tomorrow and catching up on work on Friday. So I
won't be able to get to this before the weekend. So someone else will
have to commit the patches if they want it sooner than that.
Take care.
-Eric
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
