on 12/16/99 4:46 PM, Kevin A. Burton <[EMAIL PROTECTED]> wrote:
> I am going to put it is RunDataFactory since Turbine isn't in a package.
>
> Kevin
Ok. Just saw your commits...a few things I want to see change ASAP:
#1. RunDataFactory.getRunData(). I don't think I like the method name.
Should it just be just .get()? I'm not sure how well this would play with
Reflection or not though so maybe you are correct. I'm just checking.
#2. In Turbine, I would code it this way:
RunData data = null;
try
{
data = RunDataFactory.get(req,res);
}
The reason is that things *could* throw an exception and you want to
properly catch it.
#3. I don't like having data.context (ServletContext) and data.contexts
(JNDI Context). This is very confusing. Can we please come up with better
names?
#4. throw Exception from RunDataFactory.getRunData() instead of only
throwing IOException. This will prevent having to do this in the future if
we change things.
thanks for adding all the get methods to RunData. Please also make sure that
there are also corresponding set methods as well. This is something that
should have been cleaned up long ago.
-jon
------------------------------------------------------------
To subscribe: [EMAIL PROTECTED]
To unsubscribe: [EMAIL PROTECTED]
Problems?: [EMAIL PROTECTED]
