jon * wrote:
>
> on 12/16/99 4:46 PM, Kevin A. Burton <[EMAIL PROTECTED]> wrote:
>
> > I am going to put it is RunDataFactory since Turbine isn't in a package.
> >
> > Kevin
>
> Ok. Just saw your commits...a few things I want to see change ASAP:
>
> #1. RunDataFactory.getRunData(). I don't think I like the method name.
> Should it just be just .get()? I'm not sure how well this would play with
> Reflection or not though so maybe you are correct. I'm just checking.
I like getRunData()
> #2. In Turbine, I would code it this way:
>
> RunData data = null;
> try
> {
> data = RunDataFactory.get(req,res);
> }
>
> The reason is that things *could* throw an exception and you want to
> properly catch it.
And do what? If it does throw an IOException... this is *very* bad and
we should let Turbine handle it with an error page. I mean if it can't
get an OutputStream............. we are screwed.
> #3. I don't like having data.context (ServletContext) and data.contexts
> (JNDI Context). This is very confusing. Can we please come up with better
> names?
Ouch. Good point. I didn't pay attention to data.contexts. We should
actually change both to jdniContext and servletContext with getters.
> #4. throw Exception from RunDataFactory.getRunData() instead of only
> throwing IOException. This will prevent having to do this in the future if
> we change things.
I am not sure I like this. I agree about future additions but we should
have a TurbineException which inherits from Exception. This way people
can blend this into their code as an API and be specific with regards to
an actual Turbine problem or a java problem.
I think this is the way to go.
> thanks for adding all the get methods to RunData. Please also make sure that
> there are also corresponding set methods as well. This is something that
> should have been cleaned up long ago.
I didn't modify RunData. I didn't like that had public data. Not
totally OO IMO. We should make RunData's members package private and
--
Kevin A Burton
Senior Software Engineer
Kendara Inc
http://www.kendara.com
Mobile: 408-910-6145
Linux - You *will* be assimilated
------------------------------------------------------------
To subscribe: [EMAIL PROTECTED]
To unsubscribe: [EMAIL PROTECTED]
Problems?: [EMAIL PROTECTED]
