Why is OPaL being init() in Turbine.doGet()? Shouldn't it be in
Turbine.init()? I don't see why this has to be done potentially on every
request. I think this is a bad design and I -1 it. I also want to see the
check for the JNDI init stuff also removed from doGet().
Also, I don't understand the point of wrapping all the existing
org.apache.turbine.db.* connection pooling stuff inside the stuff in
opl.database. This is bad...for example, what happens if in
PersistenceBroker.saveObject() if there is an exception thrown in the call
to processSql at the bottom? dbConn.free() will never be called and there
will be an open database connection left around. -1 on this design.
Personally, I think that you guys should get rid of that extra layer and
just use the existing methods for getting a database connection. Look in the
Peer objects that John did for examples.
-jon
--
Come to the first official Apache Software Foundation
Conference! <http://ApacheCon.Com/>
------------------------------------------------------------
To subscribe: [EMAIL PROTECTED]
To unsubscribe: [EMAIL PROTECTED]
Problems?: [EMAIL PROTECTED]
