on 1/13/00 12:12 PM, Scott Tavares <[EMAIL PROTECTED]> wrote:
> well i saw the JNDI stuff in there so i followed suite. that's what i get
> for being a follower and not a leader. i will move it.
thanks.
> i agree with you on this. the design came as a compromise. George had come
> across a GPLed connection db pooling object set and wanted to incorporate it
> directly into OPaL. This prompted you to -1 it because of the GPL part and
> you and i said that the org.apache.turbine.db.* stuff would be the better
> choice. George then came up with the idea of using an interface so that one
> could use any db pooling framework as long as it implemented the interface.
> i took that a step further and said lets make the default db broker a
> wrapped version of the org.apache.turbine.db.DBBroker and have it controlled
> through the TurbineResources.properties file.
nope. this is wrong and a complete duplicate of effort. there is no reason
why you can't already use the existing database connection pooling code as a
wrapper around another pool. look at the weblogic example that comes with it
in org.apache.turbine.util.db. It is a wrapper around weblogic's pooling
scheme. this works fine. you can plug whatever pooling code into it.
there is no reason to have connection brokering as part of OPaL. it is out
of the scope of that package and the class names being duplicated for what
is in org.apache.turbine.util.db just adds confusion.
> so this brings us to where we are, i will take a closer look at the Peer
> objects to see if i can come up with to make it better but, i'd like to hear
> what George has to say about it... George?
what i what you to look at is the fact that the release of the connection is
in a finally statement so that there is no chance that it will be left open.
the current scheme in OPaL allows that chance to happen and that is bad.
-jon
--
Come to the first official Apache Software Foundation
Conference! <http://ApacheCon.Com/>
------------------------------------------------------------
To subscribe: [EMAIL PROTECTED]
To unsubscribe: [EMAIL PROTECTED]
Problems?: [EMAIL PROTECTED]
