----- Original Message -----
From: jon * <[EMAIL PROTECTED]>
To: Turbine <[EMAIL PROTECTED]>
Sent: Thursday, January 13, 2000 2:07 PM
Subject: OPaL init in Turbine.doGet() and more
> Why is OPaL being init() in Turbine.doGet()? Shouldn't it be in
> Turbine.init()? I don't see why this has to be done potentially on every
> request. I think this is a bad design and I -1 it. I also want to see the
> check for the JNDI init stuff also removed from doGet().
>
well i saw the JNDI stuff in there so i followed suite. that's what i get
for being a follower and not a leader. i will move it.
> Also, I don't understand the point of wrapping all the existing
> org.apache.turbine.db.* connection pooling stuff inside the stuff in
> opl.database. This is bad...for example, what happens if in
> PersistenceBroker.saveObject() if there is an exception thrown in the call
> to processSql at the bottom? dbConn.free() will never be called and there
> will be an open database connection left around. -1 on this design.
>
> Personally, I think that you guys should get rid of that extra layer and
> just use the existing methods for getting a database connection. Look in
the
> Peer objects that John did for examples.
>
i agree with you on this. the design came as a compromise. George had come
across a GPLed connection db pooling object set and wanted to incorporate it
directly into OPaL. This prompted you to -1 it because of the GPL part and
you and i said that the org.apache.turbine.db.* stuff would be the better
choice. George then came up with the idea of using an interface so that one
could use any db pooling framework as long as it implemented the interface.
i took that a step further and said lets make the default db broker a
wrapped version of the org.apache.turbine.db.DBBroker and have it controlled
through the TurbineResources.properties file.
so this brings us to where we are, i will take a closer look at the Peer
objects to see if i can come up with to make it better but, i'd like to hear
what George has to say about it... George?
-scott-
------------------------------------------------------------
To subscribe: [EMAIL PROTECTED]
To unsubscribe: [EMAIL PROTECTED]
Problems?: [EMAIL PROTECTED]
