OK... go to http://suokong.e-point.pl/turbine and help yourself :)
The patch for Turbine is a bit hard to read in the places where existing
files where modified but, I guess I couldn't help that anyway.
This is unfortunate that my changes to WebMacroService required
modification of WebMacro itself. The patch is tiny and I my opinion
makes good sense, so it should be possible to get it into upstream
WebMacro.
I needed to modify their configuration provider, to make configuration
settings mutable. Otherwise I wouldn't be able to feed our template
path (procesed by getRealPath) to org.webmacro.resource.TemplateProvider
I made some changes to existing configuration arangement.
Now, all entries in TurbineResources.properties that match the following RE
^services\.(.*)\.(.*)=(.*)$
mean that a Service named $1 has a property named $2 that has value of $3
Because of this, all services have at least one property, classname
containing the name of the class implementing the service, which is
prety useless, but doesn't really hurt anything. Anyway, I find this notation
more natural than the old one.
I would like to raise another proposal when we are talking about service names.
I believe that services should be called 'Whatever' instead of
'TurbineWhateverService'.
We could make BaseServiceBroker use introspection to check if the class that was
set as implementation of service 'Whatever' implements 'WhateverService' interface.
The current syntax obscures the fact that we are requesing ANY implementation
of 'WhateverService' interface not necceserily 'TurbineWhateverService' class.
I know that shortening the names would require chaning the code in many places...
this is the only disadvantage ;)
There is another thing about the code I wrote. It is not thread safe. The old code
wasn't either (or I really overlooked something). And I believe it should be.
Anyway, I have very litle experience with concurrent programing, so I don't
feel competent to implement it. If you are - step out and finish this work.
Grab this code and test it. I'm waiting for comments and criticism.
Rafal
PS. For the people that don't feel like patching sources and reading them, there is
a war containg my current turbine.jar and webmacro.jar to play with
------------------------------------------------------------
To subscribe: [EMAIL PROTECTED]
To unsubscribe: [EMAIL PROTECTED]
Search: <http://www.mail-archive.com/turbine%40list.working-dogs.com/>
Problems?: [EMAIL PROTECTED]
