On Tue, Jul 18, 2000 at 09:41:07PM +0200, Rafal Krzewski wrote:
> This is unfortunate that my changes to WebMacroService required
> modification of WebMacro itself. The patch is tiny and I my opinion
> makes good sense, so it should be possible to get it into upstream
> WebMacro.
Hopefully - yes. The status of WM seems to be very undefined at the
moment. I made a patch for WM that allows us to use the WM ContextTool
API for out context tools but as far as I know Jon hasn't been able to
get onto shimari.com CVS to put it in.
> I would like to raise another proposal when we are talking about service names.
> I believe that services should be called 'Whatever' instead of
>'TurbineWhateverService'.
> We could make BaseServiceBroker use introspection to check if the class that was
> set as implementation of service 'Whatever' implements 'WhateverService' interface.
> The current syntax obscures the fact that we are requesing ANY implementation
> of 'WhateverService' interface not necceserily 'TurbineWhateverService' class.
> I know that shortening the names would require chaning the code in many places...
> this is the only disadvantage ;)
This certainly sounds sensible to me, ad I guess if you're going to go
gratuitously breaking stuff now is a good time :-)
> There is another thing about the code I wrote. It is not thread safe. The old code
> wasn't either (or I really overlooked something). And I believe it should be.
> Anyway, I have very litle experience with concurrent programing, so I don't
> feel competent to implement it. If you are - step out and finish this work.
Can you elaborate on what you think is not thread safe? AFAIK stuff in
init() doesn't have to be and you've got the first time request stuff
wrapped with the Turbine class-object lock.
Great work - finally we'll be able to get rid of this horrid reliance
on absolute paths!
--
Sean Legassick
[EMAIL PROTECTED]
homo sum: humani nihil a me alienum puto
------------------------------------------------------------
To subscribe: [EMAIL PROTECTED]
To unsubscribe: [EMAIL PROTECTED]
Search: <http://www.mail-archive.com/turbine%40list.working-dogs.com/>
Problems?: [EMAIL PROTECTED]
