On Wed, 26 Jul 2000, Jon Stevens wrote:
> Hey all,
>
> Now that Torque is part of Turbine (which I think is great!), I think that a
> lot of the functionality should become part of Turbine itself instead of
> being within the Torque package.
>
> Here is some constructive feedback. Please don't take it as me ordering you
> around or anything. :-)
There's only one person who can order me around ... and she
isn't on the mailing list ;) I'm in trouble now ;)
> the documentation should be converted to HTML and moved up to turbine/docs/.
No problem.
>
> The re-usable code (such as what is in Util.java) should be moved up into
> org.apache.turbine.util.
I'll do that when I clean up that Utils.java file, I've just been
stripping out the junk so when it's clean I'll it into
org.apache.turbine.util.
>
> I would like to remove (from the CVS repo) the "output" directory. (This
> will require everyone to re-check out Turbine again).
I think Jeff already took care of this, but yes it can go.
> I think that the torque.rtypes and torque.types files could be merged
> together.
Good idea, simple to do.
> This is a stupid request, but in the .sql file that is generated by Torque
> (which looks great!) could you put the ";" on its own line? The reason is
> that the software I use autogenerates files like that and it actually makes
> it easier to write a .sql file parser if that is the case.
You can simply change the required template so for mysql instead of the
default "table" template, change it to
CREATE TABLE $table
(
$columns
$primarykey
$unique
$index
)
;
You can do the same with any of the other templates, you can
format it as you like.
> system-jdbc.xml should have some sort of comments in the header stating that
> it is autogenerated.
No problem.
> XMLParser.java: It would be _really_ nice if you used SAX2 instead of a DOM
> parser.
I've never used SAX2, what's the advantage?
> DOMWriter.java: It would be _really_ nice if you simply used Xerces to
> serialize the XML. I *think* there is an easy way to do it.
You mean Xerces has a built in method now for spitting out
XML? Xerces didn't have this feature when I first made this
class.
> There are a lot of static final Strings that you are using, such as
> "primaryKey" all over the code. Those should be moved into a Constants.java
> class.
I'll take a look at that.
> Pretty much all of the non .java files in the
> org.apache.turbine.tools.torque directory should go into the config
> directory.
Good idea.
Won't take me long to make the changes. I'm currently trying to
get decent PostgreSQL, Oracle, and Hypersonic output. I'm trying
to do them all at once to see what changes have to be made.
I'll probably have some test output later on tonight.
jvz.
---
Jason van Zyl
[EMAIL PROTECTED]
------------------------------------------------------------
To subscribe: [EMAIL PROTECTED]
To unsubscribe: [EMAIL PROTECTED]
Search: <http://www.mail-archive.com/turbine%40list.working-dogs.com/>
Problems?: [EMAIL PROTECTED]
