Hey all,
Now that Torque is part of Turbine (which I think is great!), I think that a
lot of the functionality should become part of Turbine itself instead of
being within the Torque package.
Here is some constructive feedback. Please don't take it as me ordering you
around or anything. :-)
the documentation should be converted to HTML and moved up to turbine/docs/.
The re-usable code (such as what is in Util.java) should be moved up into
org.apache.turbine.util.
I would like to remove (from the CVS repo) the "output" directory. (This
will require everyone to re-check out Turbine again).
I think that the torque.rtypes and torque.types files could be merged
together.
This is a stupid request, but in the .sql file that is generated by Torque
(which looks great!) could you put the ";" on its own line? The reason is
that the software I use autogenerates files like that and it actually makes
it easier to write a .sql file parser if that is the case.
system-jdbc.xml should have some sort of comments in the header stating that
it is autogenerated.
XMLParser.java: It would be _really_ nice if you used SAX2 instead of a DOM
parser.
DOMWriter.java: It would be _really_ nice if you simply used Xerces to
serialize the XML. I *think* there is an easy way to do it.
There are a lot of static final Strings that you are using, such as
"primaryKey" all over the code. Those should be moved into a Constants.java
class.
Pretty much all of the non .java files in the
org.apache.turbine.tools.torque directory should go into the config
directory.
-jon
------------------------------------------------------------
To subscribe: [EMAIL PROTECTED]
To unsubscribe: [EMAIL PROTECTED]
Search: <http://www.mail-archive.com/turbine%40list.working-dogs.com/>
Problems?: [EMAIL PROTECTED]
