"Daniel L. Rall" wrote:
>
> How about this split:
>
> org.apache.turbine.services.db (all DB classes)
> org.apache.turbine.services.db.broker (DBBroker)
> org.apache.turbine.services.db.pool (ConnectionPool, DBFactory,
> DBConnection)
>
> This differs from the previous organization in that DBBroker and DB
> classes have been separated out into different packages than the actual
> database pool, and several methods in ConnectionPool required a lifting
> of access restrictions on methods (protected/private to public). This
> change in access level was necessary to provide DBBroker access to
> needed functionality, and to present a usefull public API to people who
> might only want to use the ConnectionPool without the broker. This is
> bad because it broadens the Turbine connection pool interface, but good
> because it lets people use Turbine on a smaller, simpler scale.
I'm against throwing stuff happily into .services. package hierarchy.
I believe that .services.whatever package should contain
- a 'whatever' service interface
- a wrapper class for the 'whatever' service
- at least one implementation of 'whatever' service.
I think it's possible to put mulitple services related to 'whatever'
in the same package.
for example:
org.apache.turbine.services.db.DBBrokerService (managing DB adapters)
org.apache.turbine.services.db.ConnectionPoolService (managing pooled connections)
with wrapper classes
org.apache.turbine.services.db.DBBroker
org.apache.turbine.services.db.ConnectionPool
and implementations
org.apache.turbine.services.db.TurbineDBBrokerService
org.apache.turbine.services.db.TurbineConnectionPoolService
All the classes that these services use for performing their duty,
should live in .util. hierarchy, for example:
org.apache.turbine.util.db.pool.DBConnection
org.apache.turbine.util.db.adapter.DB
org.apache.turbine.util.db.adapter.DBFactory
org.apache.turbine.util.db.adapter.DBOracle
org.apache.turbine.util.db.adapter.DBSybase
...
Comments?
Rafal
------------------------------------------------------------
To subscribe: [EMAIL PROTECTED]
To unsubscribe: [EMAIL PROTECTED]
Search: <http://www.mail-archive.com/turbine%40list.working-dogs.com/>
Problems?: [EMAIL PROTECTED]
