Paul O'Leary has contributed quite a bit of code and time to the Turbine
connection pool, and is obviously going to continue to contribute bug
fixes and enhancements. His patches have been of very high quality. I
would like to propose a vote that we give Paul O'Leary CVS write access.
+1 on giving Paul CVS write.
Paul O'Leary wrote:
>
> >> BTW thought I saw a couple trivial threading issues in the loaders, too.
>
> > Like? I thought that these things have been pretty well designed.
> > -jon
>
> Like this snipet from ScreenLoader is not thread safe, fer instance:
>
> public Screen getInstance (String name)
> throws Exception
> {
> Screen screen = null;
> try
> {
> if ( cache() && this.containsKey ( name ) )
> {
> screen = ( Screen ) this.get ( name );
> }
> else
>
> ScreenLoader is a GenericLoader is a Hashtable. Screen loader should
> probably sync on *this* or just have synced methods to protect its cache.
> This is something of a trivial example because it's not clear if threading
> problems could ever cause a noticeable bug here. But when I see this type
> of stuff a always go looking for other problems in similar modules.
>
> I can go through it and submit some patches for the current code or wait for
> Leon, et al's changes...?
--
Daniel Rall <[EMAIL PROTECTED]>
http://collab.net/ | open source | do the right thing
------------------------------------------------------------
To subscribe: [EMAIL PROTECTED]
To unsubscribe: [EMAIL PROTECTED]
Search: <http://www.mail-archive.com/turbine%40list.working-dogs.com/>
Problems?: [EMAIL PROTECTED]
