Fedor Karpelevitch wrote:
> I would suggest that we change table & column names in turbine to better
> match SQL naming conventions, such as:
> 
> TURBINE_PERMISSION instead of TurbinePermission
> TURBINE_ROLE_PERMISSION instead of TurbineRolePermission
> PERMISSION_ID instead of PERMISSIONID
> and GROUP_NAME instead of GROUPNAME
> 
> There are two reasons to do it: 1)it's generally a good idea to follow
> proper naming conventions 

+1 to following conventions

> 2) new torque makes better Java names
> automatically out of proper SQL names.

does SQL92 define what 'proper names' are? ;-)

I'm using Java naming conventions in my own project (i.e. Tables =
Classes,
columns = variables) and I used Java convention on table names without
thinking. My mistake. I'm going to change that to the old convention
to be consistent.

I'd like to hear other developers' opinions on using Java naming
convention
on the databases. What are the cons? Any engines that would not support 
that? We would not have db/java name dichotomy...

> I realise this may break some existing code, but really hope it should not
> be that bad. Any opinions here?

It's a breeze to fix it, since we have MapBuilders.

> It may be a wrong time to do it now, but I think this needs to be done at
> some point. And it would be harder and more painful after a public release.

agreed.

> PS. I just realised a strange thing: is there any good reason for Peers to
> refer to columns by SQL name and not by java name (*Peer.GROUP_NAME vs
> *Peer.groupName)? It seems inconsistent that you use
> TurbineGroup.getGroupName() to get the group name but refer to the column as
> to TurbineGroupPeer.GROUP_NAME
> Am I missing something?

No idea... I was following the existing code in this regard.

Rafal

--
Rafal Krzewski
Senior Internet Developer
mailto:[EMAIL PROTECTED]
+48 22 8534830 http://e-point.pl


------------------------------------------------------------
To subscribe:        [EMAIL PROTECTED]
To unsubscribe:      [EMAIL PROTECTED]
Search: <http://www.mail-archive.com/turbine%40list.working-dogs.com/>
Problems?:           [EMAIL PROTECTED]

Reply via email to