Jon Stevens wrote:
> 
> Rafal,
> 
> Can you please go over the Security code again with a fine tooth comb and
> make sure that everything that is supposed to be implemented is implemented
> properly?
> 
> I'm finding some pretty glaring obvious mistakes in there on stuff like
> synchronization missing on methods as well as forgetting to unlock shared
> resources.

Only the methods that use lockExclusive/unlockExclusive must be
synchronized.
Those using lockShared/unlockShared mustn't.

There were indeed some missing unlocks, but only unlockExclusive()s that
actually do nothing. Still, you have a point here.

I'm fixing it now.

Rafal

--
Rafal Krzewski
Senior Internet Developer
mailto:[EMAIL PROTECTED]
+48 22 8534830 http://e-point.pl


------------------------------------------------------------
To subscribe:        [EMAIL PROTECTED]
To unsubscribe:      [EMAIL PROTECTED]
Search: <http://www.mail-archive.com/turbine%40list.working-dogs.com/>
Problems?:           [EMAIL PROTECTED]

Reply via email to