On 10/03/2006, at 20:52, Michele Cella wrote: > > Isn't disabled_fields intended to be used at display time? for example > to redisplay a form without some fields? in that case the validator is > already ready, so I guess we need the ignore_missing can you give it a > shot while committing? I'm pretty sure it will fix also Jason bug.
Ok, ignore_key_missing is not that bad... > >> What I'd really like to fix when this get's in (I have a sort of >> cumbersome poor-man's svn with this patch numbering stuff :) Is the >> allow_extra_fields = True (setting it to false) and possibly adding a >> filter_extra_fields=True too. Needs some more testing though as some >> tests where failing when I tried it (probably because some input- >> expecting widget's didn't have a validator) but didn't look into it >> too closely... There's a post in this thread where I explain better >> the reasoning behind this... >> > > We may ask Kevin what's opinion, should we expect a validator for > every > field? For every field that might generate input: yes IMO. It just sounds "good parctice" to me... Kevin, where are you? :) > > - why return getattr(widget, 'full_qualified_form', True) shouldn't > this be False for default? just wondering... Because the function is called "include_in_path" :D, if there's not a full_qualified_form attribute then the field should be included... > > - can we remove compound from the base widget class? and instead use > getattr(widget, "compound", False)? it was there before but I've > removed it since it semmed silly from a parent point of view... :D Sure! :) > > Other than that, wonderful work. > > Ciao > Michele Thanks! :) Alberto P.S. Committing validation9.patch real soon (with ignore_key_missing and the compound stuff)... --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "TurboGears Trunk" group. To post to this group, send email to [EMAIL PROTECTED] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/turbogears-trunk -~----------~----~----~----~------~----~------~--~---
