Christopher Arndt schrieb:
> Christoph Zwerschke schrieb:
>> Since the parameter is called "options" in the __init__ method, it
>> makes sense to add "options" to the render method as well, not
>> "mapping" (except mapping is intended for some obscure different
>> purpose, but there is no mention of it in the docstring).
> 
> But "mapping" is also an argument to expose and _process_output, which
> the latter passes to view.render. Do you suggest to change the argument
> name there too?

Right, it's passed all along from expose to view.render. And the 
expose() function even mentions it in the docstring:

@keyparam mapping
     mapping with options that are sent to the template engine

So at least we now know that it was ideed intended to be used the way we 
have in mind, not for some other obscure purpose.

I still suggest we rename it to "options", since it's much clearer. This 
should not lead to any problems, since the old mapping parameter is not 
documented for the Buffet API and obviously has never been implemented 
by any engine adapter anyway.

-- Christoph

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"TurboGears Trunk" group.
To post to this group, send email to turbogears-trunk@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/turbogears-trunk?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to