On 5/16/07, Simon Laws <[EMAIL PROTECTED]> wrote:
On 5/16/07, Simon Nash <[EMAIL PROTECTED]> wrote: > > Simon, > Thanks for committing this. See comments inline below. > > Simon > > Simon Laws wrote: > > Ok, I took a look at the patch and committed it. I made a few minor > > changes: > > > > package name changed to crud > > > I deliberately changed the package name for the client/application code > to crudClient to make it different from the package name for the CRUD > implementation type. This helps to make it clearer which code is > which, and it is more representative of a typical user scenario > (which the samples are meant to illustrate). I am also doing this > with the client/application samples for binding-echo and > databinding-echo. > > What was the rationale for reversing this change? It was any deep reasoning - just that the capitol C looked strange in the package name so I took the word out altogether. I could have gone for crudclient instead. > include copy of composite file from implementation-crud > > > Thanks, I missed this. I did spot it for binding-echo (see my other > post) but I did not pick up on it for this sample. It should be > removed from sample-implementation-crud.jar as it does not belong > there. Moving it to src/test/resources in the implementation-crud > sample seems to work OK. OK I can fix that. > move diagrams from implementation-crud > > > I didn't do this because I thought it might be a good idea to update > the diagrams to show the client side code as well. What do you think? > What tool do you use to produce these diagrams? I haven't generally put the client code on the diagram. But I could if it makes it clearer. I'm using inkscape to produce the svgs > But looks good. > > > > Last update relating to this was at revision 538481. > > > > The binding-echo and databinding-echo tests will also change to follow > this > > pattern. > > > I'm working on these now (having solved my NoSuchMethodError problem) > and I will post patches very soon. OK, I started looking at the databinding-echo sample. Simon > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > ...or even crud.client which would make more sense I guess
Simon
