[
https://issues.apache.org/jira/browse/TUSCANY-914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466348
]
Jim Marino commented on TUSCANY-914:
------------------------------------
Hi Luciano,
Thanks for the patch. A couple of comments/suggested changes:
1. Can we change the algorithm to check against component names, service names,
and reference names as well as fail fast? We should probably keep a list of all
registered named elements and check as the each of the elements are processed.
This way, an exception can be thrown pointing to the artifact the definition is
in without continuing to process other artifacts.
2. Can you convert the LoaderException to a subclass such as
DuplicateComponent, with the name of the component being passed in the ctor as
the identifier instead of concatenating the message? This will make it
consistent with how we are doing exception handling.
3. Can you include a unit test for ComponentLoader that verfies the exception
will be thrown?
4.There are a few comments that should be stripped out including a println
Thanks,
Jim
> duplicated component name in include overwrite the using one.
> -------------------------------------------------------------
>
> Key: TUSCANY-914
> URL: https://issues.apache.org/jira/browse/TUSCANY-914
> Project: Tuscany
> Issue Type: Improvement
> Components: Java Spec APIs
> Affects Versions: Java-SCA-M3
> Reporter: Yang Lei
> Assigned To: Jim Marino
> Fix For: Java-SCA-M3
>
> Attachments: tuscany914.lresende.20070121.txt
>
>
> duplicated component name in include overwrite the using one. It may be
> better to throw duplication error.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
