[
https://issues.apache.org/jira/browse/TUSCANY-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566099#action_12566099
]
Thomas Greenwood commented on TUSCANY-1999:
-------------------------------------------
JDKInvocationHandler and RuntimeWireInvoker both trigger updates to the time
that the conversation was last used and schedule a timer - when the timer fires
the ExtendedConversationImpl. Do you think this isn't correct? I guess this
may create a certain amount of overhead.
I think you may be right that it would be better to pass the target rather than
the wire itself.
I'm not sure that the changes to JDKInvocationHandler.match actually come from
the patch file. I've been looking through it and couldn't find any reference
to method.getName() or JavaOperation.
Let me know if I can help in any way.
> ConversationAttributes and expiry doesn't work with Stateless Conversational
> components
> ---------------------------------------------------------------------------------------
>
> Key: TUSCANY-1999
> URL: https://issues.apache.org/jira/browse/TUSCANY-1999
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Core Runtime
> Affects Versions: Java-SCA-1.1
> Reporter: Ben Smith
> Assignee: Simon Laws
> Fix For: Java-SCA-Next
>
> Attachments: ConversationExpiry.patch
>
>
> In services that are marked as @Conversational yet have scope of STATELESS
> the following problems occur
> Caused by:
> org.apache.tuscany.sca.implementation.java.introspect.impl.InvalidConversationalImplementation:
> Service is marked with @ConversationAttributes but the scope is not
> @Scope("CONVERSATION")
> at
> org.apache.tuscany.sca.implementation.java.introspect.impl.ConversationProcessor.visitClass(ConversationProcessor.java:57)
> Also looking at the code it looks as if that expiring of conversations only
> occurs with services that are of scope CONVERSATION. I believe that the above
> should work with all services marked as @Conversational.
> To fix this I'm thinking that the job of expiring conversations should be
> moved from the ConversationalScopeContainer into the ConversationManager and
> the check in the ConversationProcessor changed to check for the
> @Conversational tag not @Scope("CONVERSATION")
> Ben
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
