[
https://issues.apache.org/jira/browse/TUSCANY-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566237#action_12566237
]
Simon Laws commented on TUSCANY-1999:
-------------------------------------
Sorry about that. User error. The new code I saw in JDKInvocationHandler.match
is a red herring. I just checked back on the patch and I must have applied it
to a later version so I saw the changes made at r616060 as part of your change.
Re. both client and service ends timing out the conversations. I was trying to
think if there was a specific benefit to this approach. Are you relying on this
behaviour in some way.
Re. "Wire" parameter. Ok I can adjust the fix for that.
> ConversationAttributes and expiry doesn't work with Stateless Conversational
> components
> ---------------------------------------------------------------------------------------
>
> Key: TUSCANY-1999
> URL: https://issues.apache.org/jira/browse/TUSCANY-1999
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Core Runtime
> Affects Versions: Java-SCA-1.1
> Reporter: Ben Smith
> Assignee: Simon Laws
> Fix For: Java-SCA-Next
>
> Attachments: ConversationExpiry.patch
>
>
> In services that are marked as @Conversational yet have scope of STATELESS
> the following problems occur
> Caused by:
> org.apache.tuscany.sca.implementation.java.introspect.impl.InvalidConversationalImplementation:
> Service is marked with @ConversationAttributes but the scope is not
> @Scope("CONVERSATION")
> at
> org.apache.tuscany.sca.implementation.java.introspect.impl.ConversationProcessor.visitClass(ConversationProcessor.java:57)
> Also looking at the code it looks as if that expiring of conversations only
> occurs with services that are of scope CONVERSATION. I believe that the above
> should work with all services marked as @Conversational.
> To fix this I'm thinking that the job of expiring conversations should be
> moved from the ConversationalScopeContainer into the ConversationManager and
> the check in the ConversationProcessor changed to check for the
> @Conversational tag not @Scope("CONVERSATION")
> Ben
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
