[
https://issues.apache.org/jira/browse/TUSCANY-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566553#action_12566553
]
Thomas Greenwood commented on TUSCANY-1999:
-------------------------------------------
No probs about the user error - it took me a while to check I wasn't going
insane though.
We put the time out at every use because we wanted to ensure that every place
that touched the conversation would extend the time of expiry. As long as we
are sure that the expiry happens every time the conversation is used then
that's OK. Perhaps it would make more sense for this just to happen in
RuntimeWireInvoker - as long as we are guaranteed that the timeout will be
scheduled in all circumstances.
Thanks for adjusting the wire parameter. Let me know what you think.
Thanks for spending the time looking at this.
> ConversationAttributes and expiry doesn't work with Stateless Conversational
> components
> ---------------------------------------------------------------------------------------
>
> Key: TUSCANY-1999
> URL: https://issues.apache.org/jira/browse/TUSCANY-1999
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Core Runtime
> Affects Versions: Java-SCA-1.1
> Reporter: Ben Smith
> Assignee: Simon Laws
> Fix For: Java-SCA-Next
>
> Attachments: ConversationExpiry.patch
>
>
> In services that are marked as @Conversational yet have scope of STATELESS
> the following problems occur
> Caused by:
> org.apache.tuscany.sca.implementation.java.introspect.impl.InvalidConversationalImplementation:
> Service is marked with @ConversationAttributes but the scope is not
> @Scope("CONVERSATION")
> at
> org.apache.tuscany.sca.implementation.java.introspect.impl.ConversationProcessor.visitClass(ConversationProcessor.java:57)
> Also looking at the code it looks as if that expiring of conversations only
> occurs with services that are of scope CONVERSATION. I believe that the above
> should work with all services marked as @Conversational.
> To fix this I'm thinking that the job of expiring conversations should be
> moved from the ConversationalScopeContainer into the ConversationManager and
> the check in the ConversationProcessor changed to check for the
> @Conversational tag not @Scope("CONVERSATION")
> Ben
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
