Raymond Feng wrote:
My understanding is that there are two different issues here:
1) Where definitions.xml should be packaged in a SCA contribution?
2) How do we merge multiple definitions.xml when we build the all-in-one
binary distro?
So I assume Sebastien's proposal is for 1) and the maven/shade
discussion is for 2).
Am I right? If yes, we should have two separate threads as it becomes
confusing.
My proposal handled 1 (not forcing definitions.xml to be in a fixed
location in the JAR) and 2 (as it didn't require any XML merging).
My latest comments below in this email apply to 2 (I'm basically saying
"if you really want to do this XML merging, then make sure it works").
I'm branching a new thread for 1 :)
--------------------------------------------------
From: "Jean-Sebastien Delfino" <[EMAIL PROTECTED]>
Sent: Friday, February 29, 2008 8:17 AM
To: <[email protected]>
Subject: Re: Trouble with aggregating definitions.xml in distro
Venkata Krishnan wrote:
Alright, I played around with
https://svn.apache.org/repos/asf/maven/plugins/trunk/maven-shade-plugin/src/main/java/org/apache/maven/plugins/shade/resource/XmlAppendingTransformer.javaa
bit and it seems like it gives all that I have been looking for - a
neat
aggregated xml file that is valid. I will now go and see how to plug
this
in our dist bundle.
If I understand correctly, it looks like you're now going away from
the solution we discussed before in this thread (and which was going
to work), and are going to use the above shade plugin transformer to
merge multiple definitions.xml files.
I'm OK with that if you make it really work, but at first sight the
logic in the XmlAppendingTransformer looks a little 'fragile' :)
Can you please try two things?
- two definitions.xml files that use different namespaces for their
policySets?
- two definitions.xml files that use a namespace prefix 'policy'
mapped to two different namespaces?
If it works, then, great! If it doesn't work you'll just need to write
your own shade transformer, and/or contribute a fix to Shade.
--
Jean-Sebastien
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
--
Jean-Sebastien
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
