Thanks for looking at this ant ...

<snip/>


NOTICE file still contains the incubating disclaimer


will fix

RELEASE_NOTES should have a sentence or 2 at the top saying, in a nutshell,
what is SDO. maybe also rather than saying just '...is a superset of
previous release..." make it sound a bit more exciting somehow, this is
the
1.0 release so its quite significant.


sure,  release notes was one thing on my agenda for the last changes,  i
also have to ensure the jira list is fully up to date

Not sure you really need the EPL license in the src distro license/notice

stax-api jar is included in lib dir so these days it seems like people want
mention of it in the LICENSE file even though it uses the Apache License


good point

Should sdo-api jar be named tuscany-sdo-api


i  guess, so, -- will change it

groupid of sdo-api should be org.apache.tuscany.sdo not commonj


ditto

Maybe a README in the bin distro samples folder

when i run runsamples.bat i get Exception in thread "main"
java.lang.NoClassDefFoundError:
org/apache/tuscany/samples/sdo/ExecuteSamples

Ok thats as i'd not edited BINARY_BASE, but without the README i didn't
know
i should.


sure,  I'll add one.  I think I mentioned it in the javadoc,  but I guess
the README is where you would look naturally first

Could BINARY_BASE default to ..\ so it works out of the box if you
run  it from the samples folder? Or at lest output a msg saying
BINARY_BASE
needs to be set?


yes, I'll do that

(once fixed the actual sample seems pretty cool the way it
tells you whats going on when you run it)


thanks

Has RAT been run against the distro's?


not yet, will do

  ...ant

Reply via email to