Hi Peng On 28/07/25 08:54, Peng Fan (OSS) wrote: > From: Ye Li <ye...@nxp.com> > > The ECC scruber setting is incorrect and decreases the DDR performance > in ECC enabled mode. >
nitpick: s/scruber/scrubber > Detail changes: > -Before, scrub_burst was 0; this is not allowed per SNPS umctl2 spec. > Set to "2" to align with DXL whichw as found to be most optimal setting > -Before, scrub_interval was set to 1, which means back-to-back scrubber > reads will occur very frequently, potentially effecting performance. > -Set scrub_interval to 0xFF which is the default value. However, users > can tune this to meet their system needs. > > Signed-off-by: Ye Li <ye...@nxp.com> > Signed-off-by: Oliver Chen <oliver.c...@nxp.com> > Reviewed-by: Peng Fan <peng....@nxp.com> > Signed-off-by: Peng Fan <peng....@nxp.com> I understand you are porting downstream patches and retaining the tags, but aren't both R/B and SO/B tags for a single person is redundant? I have not seen it elsewhere yet. > --- > drivers/ddr/imx/imx8m/ddr_init.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/ddr/imx/imx8m/ddr_init.c > b/drivers/ddr/imx/imx8m/ddr_init.c > index > e9209ce8b61d7ed3507bc102cc8f57ebba077067..7fdcfee1d9c982d391fe0d20e373a66d71d26e23 > 100644 > --- a/drivers/ddr/imx/imx8m/ddr_init.c > +++ b/drivers/ddr/imx/imx8m/ddr_init.c > @@ -58,9 +58,9 @@ void ddrc_inline_ecc_scrub(unsigned int start_address, > /* Step11: Disable SBR by programming SBRCTL.scrub_en=0 */ > clrbits_le32(DDRC_SBRCTL(0), 0x1); > /* Step12: Prepare for normal scrub operation(Read) and set > scrub_interval*/ > - reg32_write(DDRC_SBRCTL(0), 0x100); > + reg32_write(DDRC_SBRCTL(0), 0xFF20); > /* Step13: Enable the SBR by programming SBRCTL.scrub_en=1 */ > - reg32_write(DDRC_SBRCTL(0), 0x101); > + reg32_write(DDRC_SBRCTL(0), 0xFF21); Changing the write value to using macros like SBRBURST | SBRINTV | SBREN will help. Especially since you've mentioned that these parameters are tunable. > /* Step14: Enable AXI ports by programming */ > reg32_write(DDRC_PCTRL_0(0), 0x1); > /* Step15: Disable quasi-dynamic programming */ > -- Thanking You Neha Malcom Francis
